Cleanup reset site kit code, change test accordingly. #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaemnnosttv
requested changes
Jan 8, 2021
| @@ -85,7 +85,7 @@ describe( 'core/site reset', () => { | |||
|
|
|||
| // After a successful reset, `connection` should be `undefined` again. | |||
There was a problem hiding this comment.
This comment is no longer accurate.
Suggested change
| // After a successful reset, `connection` should be `undefined` again. | |
| // After a successful reset, `connection` state will be updated on the next page load. |
Comment on lines
86
to
88
| // After a successful reset, `connection` should be `undefined` again. | ||
| const connection = await registry.select( STORE_NAME ).getConnection(); | ||
| expect( connection ).toEqual( undefined ); | ||
| expect( connection ).toEqual( { connected: true, resettable: true } ); |
There was a problem hiding this comment.
The name of this test should also be updated to be more accurate as well.
How about: it "resets connection on server only" ? I think this would be a bit more clear as to what is going on in combination with the updated comment.
Unfortunately GitHub won't let me suggest this change because it's out of range of the current changes.
There was a problem hiding this comment.
Sure. Sounds good.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #2478
Relevant technical choices
resetChecklist