Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset dimensionColor when 'others' slice is selected. #2666

Merged
merged 1 commit into from Jan 21, 2021
Merged

Reset dimensionColor when 'others' slice is selected. #2666

merged 1 commit into from Jan 21, 2021

Conversation

johnPhillips
Copy link
Contributor

@johnPhillips johnPhillips commented Jan 21, 2021 •
edited

Summary

Selecting the 'others' slice should reset the color of the line on the userCountGraph.

Addresses issue #2625

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Jan 21, 2021
@johnPhillips johnPhillips mentioned this pull request Jan 21, 2021
Closed
@johnPhillips johnPhillips force-pushed the fix/2625-others-pie-slice-reset branch from ca09e9d to 91a673f Compare January 21, 2021 15:52
felixarntz
felixarntz approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@felixarntz felixarntz merged commit 7ca4b6c into develop Jan 21, 2021
@felixarntz felixarntz deleted the fix/2625-others-pie-slice-reset branch January 21, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene-manuilov eugene-manuilov eugene-manuilov approved these changes

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnPhillips @eugene-manuilov @felixarntz