New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/4619 backstopjs image #5692
Conversation
…ent/4619-backstopjs-image.
Size Change: 0 B Total Size: 1.5 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good and runs for me, but I have a few very minor diffs from font rendering or something that isn’t appearing in GitHub Actions 🤔
Just trying to sort that out, but after it should be good 🙂
Looks like my VRT updates still work on CI, so I think this should be good. It looks like the VRTs still run quickly despite not uploading the image to a repo, so I guess it's only built locally once? I think this is fine and we can look at uploading the image separately—this is the main thing we want (to be able to run the tests 😄 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Ran successfully for me on my M1 MacBook Pro, passes on CI, and I think we're good to go!
Thanks! 🥳
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist