Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/#7598 - Fix failing E2E tests (follow-up) #7679

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

hussain-t
Copy link
Collaborator

Summary

Addresses issue:

Relevant technical choices

  • This follow-up PR addresses the e2e test failures from conditionally setting the availableCustomDimensions option when the newsKeyMetrics feature flag is enabled.
  • Made setting the availableCustomDimensions default value unconditional to maintain consistency and prevent e2e test failures.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Build files for 530decc are ready:

Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hussain-t 👍

@aaemnnosttv aaemnnosttv merged commit 5e1f7d2 into develop Oct 9, 2023
15 of 17 checks passed
@aaemnnosttv aaemnnosttv deleted the enhance/#7598-fix-e2e-test branch October 9, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants