Improve error notification after OAuth error

[zutigrm]

Summary

Addresses issue:

• Improve error notification after OAuth error #7597

Relevant technical choices

Deviation from IB:

• Used variable name tempPersistedPermissionsError instead of permissionsError, so it is not confused with CORE_USER state, and to better describe the value it holds.
• Included isAuthenticated in checks, as during implementation/testing, this was needed to satisfy all criteria and distinguish between plugin setup error and any other other permission error notification.

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 5.6.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Build files for b019753 have been deleted.

[github-actions]

Size Change: +3.82 kB (0%)

Total Size: 1.42 MB

Filename	Size	Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css	51.8 kB	+10 B (0%)
./dist/assets/js/32-********************.js	930 B	+1 B (0%)
./dist/assets/js/googlesitekit-activation-********************.js	22.6 kB	+83 B (0%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js	54.5 kB	+279 B (+1%)
./dist/assets/js/googlesitekit-adminbar-********************.js	33.4 kB	+71 B (0%)
./dist/assets/js/googlesitekit-api-********************.js	9.95 kB	+28 B (0%)
./dist/assets/js/googlesitekit-components-gm2-********************.js	5.7 kB	-1 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js	9.17 kB	-1 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	18.2 kB	+34 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js	24.9 kB	+19 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js	68.3 kB	+281 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js	85.3 kB	+351 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js	21.4 kB	+30 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	106 kB	+267 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js	84.7 kB	+14 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	76.3 kB	+84 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	21.6 kB	-11 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	64.1 kB	+40 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	31.1 kB	+26 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js	49.4 kB	+1.05 kB (+2%)
./dist/assets/js/googlesitekit-splash-********************.js	65.8 kB	+271 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js	41.1 kB	+807 B (+2%)
./dist/assets/js/googlesitekit-vendor-********************.js	316 kB	+5 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js	32.1 kB	+30 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	61.7 kB	+55 B (0%)
./dist/assets/js/runtime-********************.js	1.3 kB	-1 B (0%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.4 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	7.58 kB
./dist/assets/js/29-********************.js	2.8 kB
./dist/assets/js/30-********************.js	2.28 kB
./dist/assets/js/31-********************.js	3.72 kB
./dist/assets/js/33-********************.js	888 B
./dist/assets/js/34-********************.js	3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	769 B
./dist/assets/js/googlesitekit-components-gm3-********************.js	10 kB
./dist/assets/js/googlesitekit-data-********************.js	2.18 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.09 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js	9.28 kB
./dist/assets/js/googlesitekit-i18n-********************.js	3.92 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	379 B

_{compressed-size-action}

[zutigrm]

Note to reviewer: e2e are failing due to new issue after puppeteer update - #7738 (comment)

[techanvil]

Looks good @zutigrm, just a handful of minor cosmetic changes to address.

[zutigrm]

@techanvil Thanks for the review. I update the PR

[techanvil]

LGTM, nice one @zutigrm!