Fix link icon alignment #7996
Merged
Fix link icon alignment #7996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 03fd24e have been deleted. |
|
Size Change: +1.25 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
aaemnnosttv
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Thanks @tofumatt – there was only one thing I found that needed fixing which I just pushed a fix for
Problem (link is off-center in mobile only)
Fix
Comment on lines
+156
to
+159
| // Set the prefix/suffix icons, based on the type of link this is and | ||
| // the props supplied. | ||
| let leadingIconToUse = leadingIcon; | ||
| let trailingIconToUse = trailingIcon; |
There was a problem hiding this comment.
IMO if an icon is passed as a prop, it should override the default icons that are related to specific kinds of links as below. It's fine for now but just a thought.
|
VRT failed in the last run before it was able to get to the comparison but passed in the previous. The only thing that changed were the Jest snapshot files and the JS tests are passing now so this is good to go now 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
I've reverted the earlier changes I made here, and fixed the ellipsis issue and the "Editin" issues. I've also audited all of the link components with icons and combined them to be consistently output using
IconWrapper, which wasn't happening before, hence the mish-mash of bugs surrounding various icons.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist