Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Audience Tile bottom margin. #8471

Merged
merged 2 commits into from Apr 3, 2024

Conversation

benbowler
Copy link
Collaborator

@benbowler benbowler commented Apr 3, 2024

Summary

Addresses issue:

Relevant technical choices

Updated the bottom margin based on QA.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@benbowler benbowler changed the base branch from develop to main April 3, 2024 11:20
Copy link

github-actions bot commented Apr 3, 2024

Build files for 09a925d have been deleted.

Copy link

github-actions bot commented Apr 3, 2024

Size Change: -2 B (0%)

Total Size: 1.42 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 53 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 930 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 778 B
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 57.3 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.1 kB
./dist/assets/js/googlesitekit-api-********************.js 10 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10 kB
./dist/assets/js/googlesitekit-data-********************.js 2.17 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.12 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 19 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 24.4 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 66.7 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 91.1 kB
./dist/assets/js/googlesitekit-modules-********************.js 21.7 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 16.8 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 111 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 111 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 57.8 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B
./dist/assets/js/googlesitekit-settings-********************.js 58.7 kB
./dist/assets/js/googlesitekit-splash-********************.js 71.9 kB
./dist/assets/js/googlesitekit-user-input-********************.js 46.8 kB
./dist/assets/js/googlesitekit-vendor-********************.js 316 kB
./dist/assets/js/googlesitekit-widgets-********************.js 33.2 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 59.9 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

@benbowler benbowler changed the base branch from main to develop April 3, 2024 12:47
@tofumatt tofumatt merged commit 5e29f17 into develop Apr 3, 2024
21 checks passed
@tofumatt tofumatt deleted the enhancement/8135-audience-tile-qa-updates branch April 3, 2024 16:55
@tofumatt
Copy link
Collaborator

tofumatt commented Apr 3, 2024

This is a release issue so should've been based off main and targeted main, but given it was straightforward to cherry-pick these commits I did that and pushed directly to main, see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants