Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct extension directives placement #21

Closed
wants to merge 1 commit into from

Conversation

digish
Copy link

@digish digish commented Jul 18, 2018

Extension directives must occur before any non-preprocessor tokens.
this will solve shader compilation errors from below generated shader

7-17 03:56:00.100 12331 12609 D skia : GLSL:
07-17 03:56:00.100 12331 12609 D skia : 1 #version 100
07-17 03:56:00.100 12331 12609 D skia : 2
07-17 03:56:00.100 12331 12609 D skia : 3 varying highp vec4 sk_FragCoord_Workaround;
07-17 03:56:00.100 12331 12609 D skia : 4 #extension GL_OES_standard_derivatives : require
07-17 03:56:00.100 12331 12609 D skia : 5 precision mediump float;
07-17 03:56:00.100 12331 12609 D skia : 6 varying mediump vec4 vQuadEdge_Stage0;
07-17 03:56:00.100 12331 12609 D skia : 7 varying mediump vec4 vinColor_Stage0;
07-17 03:56:00.100 12331 12609 D skia : 8 void main() {
07-17 03:56:00.100 12331 12609 D skia : 9 mediump vec4 outputColor_Stage0;
07-17 03:56:00.100 12331 12609 D skia : 10 mediump vec4 outputCoverage_Stage0;
07-17 03:56:00.100 12331 12609 D skia : 11 {
:

Extension directives must occur before any non-preprocessor tokens.
this will solve shader compilation errors from below generated shader

7-17 03:56:00.100 12331 12609 D skia    : GLSL:
07-17 03:56:00.100 12331 12609 D skia    :    1 #version 100
07-17 03:56:00.100 12331 12609 D skia    :    2
07-17 03:56:00.100 12331 12609 D skia    :    3 varying highp vec4 sk_FragCoord_Workaround;
07-17 03:56:00.100 12331 12609 D skia    :    4 #extension GL_OES_standard_derivatives : require
07-17 03:56:00.100 12331 12609 D skia    :    5 precision mediump float;
07-17 03:56:00.100 12331 12609 D skia    :    6 varying mediump vec4 vQuadEdge_Stage0;
07-17 03:56:00.100 12331 12609 D skia    :    7 varying mediump vec4 vinColor_Stage0;
07-17 03:56:00.100 12331 12609 D skia    :    8 void main() {
07-17 03:56:00.100 12331 12609 D skia    :    9     mediump vec4 outputColor_Stage0;
07-17 03:56:00.100 12331 12609 D skia    :   10     mediump vec4 outputCoverage_Stage0;
07-17 03:56:00.100 12331 12609 D skia    :   11     {
:
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@digish
Copy link
Author

digish commented Jul 18, 2018 via email

CarbonGerritBot pushed a commit to CarbonROM/android_external_skia that referenced this pull request Oct 20, 2018
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d79)

Signed-off-by: Joe Maples <joe@frap129.org>
ganeshi4u pushed a commit to ArrowOS/android_external_skia that referenced this pull request Oct 28, 2018
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d79)
CarbonGerritBot pushed a commit to CarbonROM/android_external_skia that referenced this pull request Nov 10, 2018
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d79)

Signed-off-by: Joe Maples <joe@frap129.org>
CarbonGerritBot pushed a commit to CarbonROM/android_external_skqp that referenced this pull request Nov 10, 2018
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d79)

Signed-off-by: Joe Maples <joe@frap129.org>
mohancm pushed a commit to DotOS/android_external_skia that referenced this pull request Nov 12, 2018
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d790df6596c21a9e01ed6dadb680d7fe19e5)
wloot pushed a commit to android-mod/external_skia that referenced this pull request Dec 17, 2018
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d790df6596c21a9e01ed6dadb680d7fe19e5)
wloot pushed a commit to android-mod/external_skia that referenced this pull request Jan 6, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d790df6596c21a9e01ed6dadb680d7fe19e5)

Signed-off-by: Joe Maples <joe@frap129.org>
mydongistiny pushed a commit to BenzoRom/external_skia that referenced this pull request Jan 25, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
mydongistiny pushed a commit to BenzoRom/external_skqp that referenced this pull request Jan 25, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
mydongistiny pushed a commit to BenzoRom/external_skia that referenced this pull request Jan 25, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
SKULSHADY pushed a commit to Havoc-OS/android_external_skqp that referenced this pull request Feb 3, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
wloot pushed a commit to android-mod/external_skia that referenced this pull request Feb 6, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d790df6596c21a9e01ed6dadb680d7fe19e5)

Signed-off-by: Joe Maples <joe@frap129.org>
Tomoms pushed a commit to Tomoms/android_external_skia that referenced this pull request Feb 9, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
spezi77 pushed a commit to pixeldustproject-p/android_external_skia that referenced this pull request Feb 27, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
Signed-off-by: spezi77 <spezi7713@gmx.net>
mydongistiny pushed a commit to BenzoRom/external_skia that referenced this pull request Mar 4, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
mydongistiny pushed a commit to BenzoRom/external_skqp that referenced this pull request Mar 4, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
CarbonGerritBot pushed a commit to CarbonROM/android_external_skia that referenced this pull request May 10, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d79)

Signed-off-by: Joe Maples <joe@frap129.org>
charleseb pushed a commit to MotorolaMobilityLLC/external-skia that referenced this pull request Jul 5, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Mot-CRs-Fixed: (CR)

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
(cherry-picked from cc10d79)
Reviewed-on: https://gerrit.mot.com/1313961
SLTApproved: Slta Waiver
SME-Granted: SME Approvals Granted
Tested-by: Jira Key
Reviewed-by: Cesar Augusto Marcelino dos Santos <cmsantos@motorola.com>
Reviewed-by: Shuo Yan <shuoyan@motorola.com>
Reviewed-by: Yinjun Chen <a7301c@motorola.com>
Submit-Approved: Jira Key
Tomoms pushed a commit to Tomoms/android_external_skia that referenced this pull request Jul 15, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
TheHardGamer pushed a commit to Bootleg-P/external_skia that referenced this pull request Dec 4, 2019
This ensures that all extension directives occur before any
non-preprocessor tokens, as required by the spec (§ 3.4).

This was found by Qualcomm, and originally submitted as
google/skia#21

Bug: b/111525079
Change-Id: I24357e4d3654e76c2dfbc067aca3088948dfa5a8
Reviewed-on: https://skia-review.googlesource.com/142697
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Signed-off-by: mydongistiny <jaysonedson@gmail.com>
@rmistry
Copy link
Contributor

rmistry commented Dec 10, 2020

Closing old PRs with merge conflicts

@rmistry rmistry closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants