Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

DRY (Do not repeat yourself) - Branch name should be global constant #1

Closed
mithro opened this issue Mar 12, 2021 · 0 comments · Fixed by #3
Closed

DRY (Do not repeat yourself) - Branch name should be global constant #1

mithro opened this issue Mar 12, 2021 · 0 comments · Fixed by #3
Labels
cleanup Something which needs to be cleanup.

Comments

@mithro
Copy link
Contributor

mithro commented Mar 12, 2021

Currently the code is littered with 'pullrequest/temp/{0}/{1}/{2} like sequences. This makes it hard to quickly change the sequence. It should be something like;

GH_PULLREQUEST_NAMESPACE = 'pullrequest/temp/{pr_id}/{seq_id}/{branch}'

def myfunc(xxx):
    a = GH_PULLREQUEST_NAMESPACE.format(pr_id=pull_request_id, seq_id=0, branch='master')
@mithro mithro added the cleanup Something which needs to be cleanup. label Mar 12, 2021
agorararmard added a commit to agorararmard/skywater-pdk-actions that referenced this issue Mar 22, 2021
@mithro mithro closed this as completed in #3 Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup Something which needs to be cleanup.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant