Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nwell resistor did not get a new name #168

Closed
RTimothyEdwards opened this issue Oct 6, 2020 · 0 comments · Fixed by #190
Closed

Nwell resistor did not get a new name #168

RTimothyEdwards opened this issue Oct 6, 2020 · 0 comments · Fixed by #190
Assignees
@mithro
Labels
files-model-spice Issues related to Spice model files. in-progress This issue has someone already working on solving it and has made substantial progress. lib-sky130_fd_pr Issues with the base primitive cells provided by the SkyWater foundry. type-bug Something isn't working

Comments

@RTimothyEdwards
Copy link
Collaborator

File "sky130_rf_pr__model__r+c.model.spice" has all the resistor ".model" model names changed to "sky130_fd_pr__" nomenclature. There are a bunch of modeled resistances for contacts that also do not follow that pattern, but since nobody would draw a via as a resistor, I don't think a name change is warrented there. But nwell resistors are often used, and it should be available as a device. The current name of the nwell resistor is "mrnw" and the new name should be "sky130_fd_pr__res_generic_nw".
@mithro mithro self-assigned this Oct 24, 2020
@mithro mithro added files-model-spice Issues related to Spice model files. lib-sky130_fd_pr Issues with the base primitive cells provided by the SkyWater foundry. type-bug Something isn't working in-progress This issue has someone already working on solving it and has made substantial progress. labels Oct 24, 2020
mithro added a commit to mithro/skywater-pdk that referenced this issue Oct 26, 2020
@mithro
Updating submodules on 2020-10-25 23:59:18 UTC
bf36a76 
Fixes the name of the nwell and rdl generic resistors in the SkyWater
primitive library (`sky130_fd_pr`).

Fixes google#168.

 - Updating [`sky130_fd_pr` latest](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.1..v0.20.0-10-g3195d6d) to v0.20.0-10-g3195d6d
 - Updating [`sky130_fd_pr` v0.0.9](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.0.9..v0.0.9-1-g88be317) to v0.0.9-1-g88be317
 - Updating [`sky130_fd_pr` v0.10.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.10.0..v0.10.0-2-g4ef3a9f) to v0.10.0-2-g4ef3a9f
 - Updating [`sky130_fd_pr` v0.10.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.10.1..v0.10.1-3-g78516f4) to v0.10.1-3-g78516f4
 - Updating [`sky130_fd_pr` v0.11.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.11.0..v0.11.0-4-gb192529) to v0.11.0-4-gb192529
 - Updating [`sky130_fd_pr` v0.12.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.12.0..v0.12.0-5-gc639b95) to v0.12.0-5-gc639b95
 - Updating [`sky130_fd_pr` v0.12.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.12.1..v0.12.1-6-g78ec0b6) to v0.12.1-6-g78ec0b6
 - Updating [`sky130_fd_pr` v0.13.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.13.0..v0.13.0-7-gef7ae9d) to v0.13.0-7-gef7ae9d
 - Updating [`sky130_fd_pr` v0.20.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.0..v0.20.0-8-g668e396) to v0.20.0-8-g668e396
 - Updating [`sky130_fd_pr` v0.20.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.1..v0.20.1-9-g3195d6d) to v0.20.1-9-g3195d6d

 * libraries/sky130_fd_pr/latest d717cd4...3195d6d (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.0.9 33b7687...88be317 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.10.0 77429bf...4ef3a9f (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.10.1 aff6c99...78516f4 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.11.0 a7a4ba1...b192529 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.12.0 56eb01d...c639b95 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.12.1 48bb19e...78ec0b6 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.13.0 2997061...ef7ae9d (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.20.0 6d4ff0d...668e396 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.20.1 d717cd4...3195d6d (1):
   > Fix the name of nwell and rdl generic resistors.

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro mithro mentioned this issue Oct 26, 2020
Merged
mithro added a commit to mithro/skywater-pdk that referenced this issue Oct 26, 2020
@mithro
Updating submodules on 2020-10-25 23:59:18 UTC
826b629 
Fixes the name of the nwell and rdl generic resistors in the SkyWater
primitive library (`sky130_fd_pr`).

Fixes google#168.

 - Updating [`sky130_fd_pr` latest](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.1..v0.20.0-10-g3195d6d) to v0.20.0-10-g3195d6d
 - Updating [`sky130_fd_pr` v0.0.9](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.0.9..v0.0.9-1-g88be317) to v0.0.9-1-g88be317
 - Updating [`sky130_fd_pr` v0.10.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.10.0..v0.10.0-2-g4ef3a9f) to v0.10.0-2-g4ef3a9f
 - Updating [`sky130_fd_pr` v0.10.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.10.1..v0.10.1-3-g78516f4) to v0.10.1-3-g78516f4
 - Updating [`sky130_fd_pr` v0.11.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.11.0..v0.11.0-4-gb192529) to v0.11.0-4-gb192529
 - Updating [`sky130_fd_pr` v0.12.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.12.0..v0.12.0-5-gc639b95) to v0.12.0-5-gc639b95
 - Updating [`sky130_fd_pr` v0.12.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.12.1..v0.12.1-6-g78ec0b6) to v0.12.1-6-g78ec0b6
 - Updating [`sky130_fd_pr` v0.13.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.13.0..v0.13.0-7-gef7ae9d) to v0.13.0-7-gef7ae9d
 - Updating [`sky130_fd_pr` v0.20.0](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.0..v0.20.0-8-g668e396) to v0.20.0-8-g668e396
 - Updating [`sky130_fd_pr` v0.20.1](https://foss-eda-tools.googlesource.com/skywater-pdk/libs/sky130_fd_pr/+/v0.20.1..v0.20.1-9-g3195d6d) to v0.20.1-9-g3195d6d

 * libraries/sky130_fd_pr/latest d717cd4...3195d6d (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.0.9 33b7687...88be317 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.10.0 77429bf...4ef3a9f (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.10.1 aff6c99...78516f4 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.11.0 a7a4ba1...b192529 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.12.0 56eb01d...c639b95 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.12.1 48bb19e...78ec0b6 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.13.0 2997061...ef7ae9d (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.20.0 6d4ff0d...668e396 (1):
   > Fix the name of nwell and rdl generic resistors.

 * libraries/sky130_fd_pr/v0.20.1 d717cd4...3195d6d (1):
   > Fix the name of nwell and rdl generic resistors.

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
88be317 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
4ef3a9f 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
78516f4 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
b192529 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
c639b95 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
78ec0b6 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
ef7ae9d 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
668e396 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
eskiyerli pushed a commit to eskiyerli/sky130_reveda that referenced this issue Oct 8, 2021
@mithro
Fix the name of nwell and rdl generic resistors.
3195d6d 
Convert `mrnw` to `sky130_fd_pr__res_generic_nw`.
Convert `mrrdl` to `sky130_fd_pr__res_generic_r1`.

Fixes google/skywater-pdk#168

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mithro mithro

Labels
files-model-spice Issues related to Spice model files. in-progress This issue has someone already working on solving it and has made substantial progress. lib-sky130_fd_pr Issues with the base primitive cells provided by the SkyWater foundry. type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to the primitive libraries. mithro/skywater-pdk
2 participants
@mithro @RTimothyEdwards