Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periphery csv description line break handling #208

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Periphery csv description line break handling #208

merged 1 commit into from
Nov 5, 2020

Conversation

wgryncewicz
Copy link
Collaborator

@wgryncewicz wgryncewicz commented Nov 5, 2020 •
edited by mithro

Fixes periphery-rules generation script and resulting rst by;

  • Handles '\n' in CSV rules description strings.
  • Multi-line descriptions and bullet lists are handled separately.
  • Single item bullet lists without header are reduced to text.

Fixes #71

@wgryncewicz
csv description line break handling
93b039d 
Signed-off-by: Wojciech Gryncewicz <wgryncewicz@antmicro.com>

periphery csv description line break handling

Signed-off-by: Wojciech Gryncewicz <wgryncewicz@antmicro.com>

Reduction of one item lists

Signed-off-by: Wojciech Gryncewicz <wgryncewicz@antmicro.com>
mithro
mithro approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mithro mithro merged commit de673cb into google:master Nov 5, 2020
@wgryncewicz wgryncewicz deleted the 71_periphery_rules_n_fix branch November 6, 2020 09:42
@mithro mithro mentioned this pull request Nov 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Periphery rules contains several 'n' instead of newline
2 participants
@wgryncewicz @mithro