error variable measurement #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this ! Could you please sign the CLA at https://cla.developers.google.com/ so that I can merge your PR ? Thank you. |
This was referenced Jan 24, 2022
|
Close to reopen it after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a run slo-generator compute i got two errors
it seems code in dynatrace.py to get slo measurement is not good
i have replace
conf = slo_config['backend']
measurement = conf['measurement']
by
measurement = slo_config['spec']['service_level_indicator']
(same as in datadog.py)
ERRORS
conf = slo_config['backend']
KeyError: 'backend'
then
Traceback (most recent call last):
File "/home/laurendeau/project/slo-generator-project/venv/lib/python3.8/site-packages/slo_generator/report.py", line 216, in run_backend
data = method(self.timestamp, self.window, config)
File "/home/laurendeau/project/slo-generator-project/venv/lib/python3.8/site-packages/slo_generator/backends/dynatrace.py", line 58, in query_sli
measurement = conf['measurement']