Specifically check for NEON for ARMv8 CPUs #169
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual NEON implementation uses instructions that are not supported on 32-bit CPUs. These errors happen when building for armv7a:
This PR just makes the CMake test use the
vmaxvq_u8
intrinsic to find the maximum vector element to test for A64 NEON, since that's an instruction used in the code. You can check supported instruction targets here: https://arm-software.github.io/acle/neon_intrinsics/advsimd.html