distinguish library name for static build on MSVC

[djsutherland]

On Windows, whether you build with BUILD_SHARED_LIBS or not, the library is still named snappy.lib. This is confusing compared to the Unix case, where it's libsnappy.a for static libs and libsnappy.so or libsnappy.dylib for dynamic libraries, and makes it impossible to install both a static and a dynamic lib at the same time.

This patch names the static library snappy_static.lib on Windows to avoid that.

It's maybe a little bit weird to have the default behavior not produce something named snappy.lib, but snappy_static.lib is the name that we've already shipped with in conda-forge for what that's worth.

[Optiligence]

It’s also possible to rename the dll import lib using IMPORT_SUFFIX to avoid different names for the actual libraries.

PS: It’s a little confusing to read windows when only msvc is affected.

[djsutherland]

@Optiligence What would a typical project set IMPORT_SUFFIX to?

[Optiligence]

idk, I would set it to _imp, or .imp if you want to be fancy (that could create its own problems tho).

[cmumford]

@googlebot rescan

[pwnall]

Thank you for your contribution!

We're not currently interested in contributions to the build configuration. We now have a paragraph explaining the situation in https://github.com/google/snappy/blob/master/README.md#contributing-to-the-snappy-project