Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt require Gtest,Gflags, Threads if building tests #63

Closed
wants to merge 1 commit into from

Conversation

nmushell
Copy link

If you have are going to build tests SNAPPY_BUILD_TESTS you will require gflag and gtest libraries. Let's make them required and move the find_package into the if(SNAPPY_BUILD_TESTS) code block when.

This PR is similar to #62

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@nmushell
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@cmumford
Copy link
Contributor

@googlebot rescan

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@ghost
Copy link

ghost commented Mar 10, 2021

@cmumford , this one looks outdated/obsolete

@pwnall
Copy link
Member

pwnall commented Jan 12, 2022

Thank you for your contribution!

We're not currently interested in contributions to the build configuration. We now have a paragraph explaining the situation in https://github.com/google/snappy/blob/master/README.md#contributing-to-the-snappy-project

@pwnall pwnall closed this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants