teach souper about data flow fact isKnownNegative #247
Conversation
|
Jubi I think we want the flags to be symmetrical. That is, we don't want Negative and NonNegative. Rather, we want NonNegative and NonPositive. |
|
Then NonNegative + NonZero = Positive and NonPositive + NonZero = Negative |
|
In my knowledge, there is no data flow function in LLVM to determine non-positive so far. If you want we can implement our own function, may be? |
|
I agree it will be good to have symmetrical flags actually. Since I didn't find non-positive, I thought it will be good enough to add an extra flag. |
|
I see, I thought I saw a non-positive call. Let me think about this a bit more. |
|
Sure. |
jubitaneja
force-pushed
the
known-negative
branch
from
36212a4
to
ac607cf
Compare
lib/Parser/Parser.cpp
Outdated
| ErrStr = makeErrStr(TP, "repeated '-' flag"); | ||
| return false; | ||
| } | ||
| Negative = true; |
There was a problem hiding this comment.
indentation looks a bit messed up here
There was a problem hiding this comment.
Fixed. The tabs were sitting in Parser.cpp in previous commits too. Hope it looks fine now.
This is represented as: var (-)
jubitaneja
force-pushed
the
known-negative
branch
from
ac607cf
to
14701f2
Compare
This is represented as: var (-)