Add django version information #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least Django version 2.0 is required as sqlcommenter makes use of DatabseWrapper.execute_wrapper. This implicitly means that python3.4 or higher is required too as that's what Django 2.0 supports
balachandr
reviewed
Jan 30, 2021
| @@ -29,6 +29,8 @@ pip3 install google-cloud-sqlcommenter[opentelemetry] | |||
|
|
|||
| ### Django | |||
|
|
|||
| > Django version 2.0 or higher is required | |||
omirho
reviewed
Feb 16, 2021
There was a problem hiding this comment.
@switchtrue Thanks for bringing this to our notice.
This information is now available on the top of the python readme.
Closing this PR.
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least Django version 2.0 is required as sqlcommenter makes use of DatabseWrapper.execute_wrapper.
This implicitly means that python3.4 or higher is required too as that's what Django 2.0 supports