starlark: tweak how UnpackArgs enforces optional args #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
commented
May 6, 2024
adonovan
reviewed
May 6, 2024
starlark/eval_test.go
Outdated
| "x", &x, "y?", &y, "z", &z); err != nil { | ||
| t.Errorf("UnpackArgs failed: %v", err) | ||
| } | ||
| if x != 1 { |
There was a problem hiding this comment.
You can achieve higher vertical density (and, in this case, readability) in both the code and the test log by combining all three in one line:
got := fmt.Sprint("x=%d y=%d z=%d", x, y, z)
want := "x=1 y=2 z=0"
...assert...
| @@ -164,12 +163,15 @@ kwloop: | |||
| } | |||
|
|
|||
| // Check that all non-optional parameters are defined. | |||
| // (We needn't check the first len(args).) | |||
| for i := len(args); i < nparams; i++ { | |||
| for i := 0; i < nparams; i++ { | |||
| name := pairs[2*i].(string) | |||
| if strings.HasSuffix(name, "?") { | |||
| break // optional | |||
There was a problem hiding this comment.
The doc comment says "If a parameter is marked optional, then all following parameters are implicitly optional whether or not they are marked." In hindsight we should probably have disallowed non-optionals after optionals, but that would be a breaking change now.
Fixes google#544 Signed-off-by: Nick Santos <nick.santos@docker.com>
adonovan
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #544