Web login - simple html + js version #519
Conversation
| @@ -0,0 +1,20 @@ | |||
| .google { | |||
There was a problem hiding this comment.
Can we do it reasonably without the login-with-google.png and favicon.ico?
| Log Out | ||
| </button> | ||
| </div> | ||
| <div class="chrome" id="chrome">For best support please open chrome</div> |
| Log Out | ||
| </button> | ||
| </div> | ||
| <div class="chrome" id="chrome">For best support please open chrome</div> |
|
|
||
| ### Development | ||
| ``` | ||
| npm start |
There was a problem hiding this comment.
If this is just plain HTML+js, why do we need npm? Please document.
There was a problem hiding this comment.
There was a small development expressjs server, which launched the HTML+js code locally.
expressjs requires npm.
But we can run localserver from outside, it doesn't have to be part of the project. So I removed it.
| @@ -0,0 +1,27 @@ | |||
| { | |||
There was a problem hiding this comment.
Cool! Maybe we can further simplify by putting all the js inside the html file?
That way you can actually open the file in the browser and it will work, you don't need a server.
Or is that frowned upon? :-)
There was a problem hiding this comment.
Looks like we can't work with firebase, when all the code is launched from a single file.
Error:
This operation is not supported in the environment…chrome-extension and web storage must be enabled.
There was a problem hiding this comment.
You can try, if you'd like:
https://github.com/google/startup-os/blob/singlefile/tools/reviewer/local_server/web_login_js/src/index.html
There was a problem hiding this comment.
But the file works, if it's launched from a server.
So I can put everything in one file, but there's no much sense in it.
There was a problem hiding this comment.
Ok, let's still keep it in one file. I think it will be easier to host it that way.
No description provided.