Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

fix bugs related to introduction of flag --blocksize_kb #213

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

emillynge
Copy link
Contributor

Dear maintainers

Please accept this PR which fixes a couple of issues that has arisen due to the introduction of --blocksize_kb option.

In general these issue stem from the previous assumption that a block is 1MB.

The stats MBps and MB are wrong when bz!=1MB
Files are not rotated at the right time. Specifically, bz>1MB can lead to a PKT file larger than 4Gb which causes a fatal error.
To fix the issue, i've introduced a new variable blocks_per_file which is determined by the values flag_filesize_mband flag_blocksize_kb.

I'm not entirely sure whether the pattern of calculating blocks_per_file in the switch block is the right way to go.

NB: closed previous PR in order to create PR from company repo instead

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@emillynge
Copy link
Contributor Author

@googlebot I signed it!

3 similar comments
@wehowsky-admin
Copy link

@googlebot I signed it!

@emillynge
Copy link
Contributor Author

@googlebot I signed it!

@emillynge
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gconnell
Copy link
Contributor

gconnell commented Nov 4, 2019

Thanks, and sorry for the late reply!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants