This repository has been archived by the owner on Nov 4, 2022. It is now read-only.
fix bugs related to introduction of flag --blocksize_kb #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear maintainers
Please accept this PR which fixes a couple of issues that has arisen due to the introduction of --blocksize_kb option.
In general these issue stem from the previous assumption that a block is 1MB.
The stats MBps and MB are wrong when bz!=1MB
Files are not rotated at the right time. Specifically, bz>1MB can lead to a PKT file larger than 4Gb which causes a fatal error.
To fix the issue, i've introduced a new variable blocks_per_file which is determined by the values flag_filesize_mband flag_blocksize_kb.
I'm not entirely sure whether the pattern of calculating blocks_per_file in the switch block is the right way to go.
NB: closed previous PR in order to create PR from company repo instead