Skip to content
This repository has been archived by the owner on Dec 14, 2017. It is now read-only.

SimpleRequestHandler should close its stream on completion #270

Open
gsadams opened this issue Nov 11, 2014 · 0 comments
Open

SimpleRequestHandler should close its stream on completion #270

gsadams opened this issue Nov 11, 2014 · 0 comments

Comments

@gsadams
Copy link
Contributor

gsadams commented Nov 11, 2014

The SimpleRequestHandler (in lib/impl.dart) doesn't close its stream after it receives a server response. Otherwise, the stream (and any listeners subscribed to it) will hang around indefinitely.

An example of the correct behavior is in ProxyClient (lib/runtime/proxy.dart). Notice that it calls c.close() both on success and error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant