Skip to content
This repository has been archived by the owner on Dec 14, 2017. It is now read-only.

Add the concept of an Http handler to ProxyClient, with a dart:html implementation as the default. #14

Merged
merged 6 commits into from Jul 3, 2013

Conversation

alxhub
Copy link
Contributor

@alxhub alxhub commented Jul 3, 2013

No description provided.

@ghost ghost assigned yjbanov Jul 3, 2013
StreamyHttpResponse(this.statusCode, this.statusText, this.body);
}

abstract class StreamyHttpHandler {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I weren't looking at this code, then the name of this class would make me think it implements the RequestHandler interface. How about HttpService?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yjbanov
Copy link
Member

yjbanov commented Jul 3, 2013

LGTM

alxhub added a commit that referenced this pull request Jul 3, 2013
Add the concept of an Http handler to ProxyClient, with a dart:html implementation as the default.
@alxhub alxhub merged commit 05d450e into google:master Jul 3, 2013
@albertog albertog mentioned this pull request Dec 30, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants