Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript styleguide is outdated compared to internal JS style #462

Closed
freshp86 opened this issue Aug 8, 2019 · 0 comments
Closed

Javascript styleguide is outdated compared to internal JS style #462

freshp86 opened this issue Aug 8, 2019 · 0 comments

Comments

@freshp86
Copy link
Contributor

freshp86 commented Aug 8, 2019

It seems that the Javascript styleguide has not been updated for a while. Specifically see https://google.github.io/styleguide/jsguide.html#file-es6-modules where Javascript modules are banned, whereas they are allowed in Google's internal style.

Could we update the external styleguide? The motivation to update is that we would like to follow it from the Chromium codebase, which is in the process of allowing JS modules usage, see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/-vm0FX3euDc/ueyKDDWQFAAJ.

cc @danbeam

@shicks shicks closed this as completed in dceb47f Aug 27, 2019
zasgar pushed a commit to pixie-io/cpplint that referenced this issue Sep 2, 2021
Update JS styleguide

Closes google#462.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant