This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Add linter config and fix all lint warnings. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use, run `nox -s lint`.
liyanhui1228
approved these changes
Nov 8, 2017
nox.py
Outdated
|
|
||
| @nox.session | ||
| def lint(session): | ||
| session.interpreter = 'python3' # So it understands Python3 syntax |
There was a problem hiding this comment.
Specify the version like python3.6?
There was a problem hiding this comment.
Any version 3.0 or above works. I dug deeper, and the real problem is a Unicode problem with Python 2. So I updated the comment. Note that regular Python installs, and virtualenv -p python 3.anything creates a bin/python3 symlink, so this should ok.
|
Moved the flake8 command line arguments to a configuration file, and fixed some lint warnings that came in with the merge from head. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use, run
nox -s lint.