Process Link header for cache requirements. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse and transform the Link header to meet the Google SXG Cache requirements at https://github.com/google/webpackager/blob/main/docs/cache_requirements.md. Directives are omitted if they have an invalid rel or crossorigin or an unknown param name. Hrefs are converted to absolute URLs. Preloads are limited to 20. imagesrcset and imagesizes are not yet validated. A future commit will compute header-integrity and add appropriate allowed-alt-sxg directives.
banaag
reviewed
Sep 2, 2021
antiphoton
approved these changes
Sep 2, 2021
banaag
approved these changes
Sep 3, 2021
Co-authored-by: Boxiao Cao <9083193+antiphoton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse and transform the Link header to meet the Google SXG Cache requirements
at https://github.com/google/webpackager/blob/main/docs/cache_requirements.md.
Directives are omitted if they have an invalid rel or crossorigin or an unknown
param name. Hrefs are converted to absolute URLs. Preloads are limited to 20.
imagesrcset and imagesizes are not yet validated.
A future commit will compute header-integrity and add appropriate
allowed-alt-sxg directives.
Addresses #13.