Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export worker class to JavaScript #71

Merged
merged 7 commits into from Sep 24, 2021
Merged

Export worker class to JavaScript #71

merged 7 commits into from Sep 24, 2021

Conversation

antiphoton
Copy link
Collaborator

@antiphoton antiphoton commented Sep 22, 2021 •
edited

Export a WasmWorker class to JavaScript. Hence JavaScript developers are able to construct multiple WasmWorker instances for different domains.

  • Remove most functions in cloudflare_worker/src/*.rs. They are now member methods of class WasmWorker.
  • Remove dependencies in cloudflare_worker/Cargo.toml.
  • Remove the SxgWorker global variable in cloudflare_worker/src/lib.rs. it is now a WasmWorker global variable in TypeScript.
  • Remove get_last_error_message.
  • Change constructor of SxgWorker to return a Result.

Closes #46

@antiphoton antiphoton mentioned this pull request Sep 22, 2021
Merged
twifkak
twifkak requested changes Sep 23, 2021
View reviewed changes
cloudflare_worker/worker/src/wasmFunctions.ts Show resolved Hide resolved
sxg_rs/src/lib.rs Outdated Show resolved Hide resolved
sxg_rs/src/wasm_worker.rs Outdated Show resolved Hide resolved
sxg_rs/src/utils.rs Outdated Show resolved Hide resolved
sxg_rs/src/wasm_worker.rs Outdated Show resolved Hide resolved
sxg_rs/src/wasm_worker.rs Show resolved Hide resolved
twifkak
twifkak reviewed Sep 23, 2021
View reviewed changes
cloudflare_worker/worker/src/wasmFunctions.ts Outdated Show resolved Hide resolved
cloudflare_worker/worker/src/wasmFunctions.ts Outdated Show resolved Hide resolved
sxg_rs/src/utils.rs Outdated Show resolved Hide resolved
cloudflare_worker/worker/src/wasmFunctions.ts Show resolved Hide resolved
@antiphoton antiphoton enabled auto-merge (squash) September 24, 2021 00:09
@antiphoton antiphoton merged commit 8739146 into google:main Sep 24, 2021
@antiphoton antiphoton deleted the bindgen branch September 24, 2021 01:24
@antiphoton antiphoton mentioned this pull request Oct 7, 2021
Merged
@twifkak twifkak mentioned this pull request Oct 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twifkak twifkak twifkak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export constructor of SxgWorker to WebAssembly
2 participants
@antiphoton @twifkak