Skip to content

Commit

Permalink
dashboard/app: add bisection link to emails
Browse files Browse the repository at this point in the history
Add link to more information about bisection process
to emails that contain bisection results.
This seems to be a hot topic for questions.

Update #501
  • Loading branch information
dvyukov committed Mar 22, 2019
1 parent dce6e62 commit 40fdabd
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 7 deletions.
13 changes: 10 additions & 3 deletions dashboard/app/bisect_test.go
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ C reproducer: %[7]v
Reported-by: syzbot+%[1]v@testapp.appspotmail.com Reported-by: syzbot+%[1]v@testapp.appspotmail.com
Fixes: 36e65cb4a044 ("kernel: add a bug") Fixes: 36e65cb4a044 ("kernel: add a bug")
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
`, extBugID, bisectLogLink, bisectCrashReportLink, bisectCrashLogLink, kernelConfigLink, reproSyzLink, reproCLink)) `, extBugID, bisectLogLink, bisectCrashReportLink, bisectCrashLogLink, kernelConfigLink, reproSyzLink, reproCLink))


syzRepro := []byte(fmt.Sprintf("%s#%s\n%s", syzReproPrefix, crash2.ReproOpts, crash2.ReproSyz)) syzRepro := []byte(fmt.Sprintf("%s#%s\n%s", syzReproPrefix, crash2.ReproOpts, crash2.ReproSyz))
Expand Down Expand Up @@ -214,7 +216,8 @@ See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See: syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot. https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this bug, for details see: syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches`, https://goo.gl/tpsmEJ#testing-patches`,
extBugID2, crashLogLink, kernelConfigLink, reproSyzLink, reproCLink, extBugID2, crashLogLink, kernelConfigLink, reproSyzLink, reproCLink,
Expand Down Expand Up @@ -344,6 +347,7 @@ dashboard link: https://testapp.appspot.com/bug?extid=%[1]v
syz repro: %[4]v syz repro: %[4]v
C reproducer: %[5]v C reproducer: %[5]v
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
`, extBugID, bisectLogLink, kernelConfigLink, reproSyzLink, reproCLink)) `, extBugID, bisectLogLink, kernelConfigLink, reproSyzLink, reproCLink))
} }


Expand Down Expand Up @@ -388,7 +392,8 @@ See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See: syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot. https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this bug, for details see: syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches`, https://goo.gl/tpsmEJ#testing-patches`,
extBugID2, crashLogLink, kernelConfigLink, reproSyzLink, reproCLink, bisectLogLink)) extBugID2, crashLogLink, kernelConfigLink, reproSyzLink, reproCLink, bisectLogLink))
Expand Down Expand Up @@ -448,6 +453,7 @@ dashboard link: https://testapp.appspot.com/bug?extid=%[1]v
syz repro: %[6]v syz repro: %[6]v
C reproducer: %[7]v C reproducer: %[7]v
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
`, extBugID, bisectLogLink, bisectCrashReportLink, bisectCrashLogLink, `, extBugID, bisectLogLink, bisectCrashReportLink, bisectCrashLogLink,
kernelConfigLink, reproSyzLink, reproCLink)) kernelConfigLink, reproSyzLink, reproCLink))
} }
Expand Down Expand Up @@ -492,7 +498,8 @@ See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See: syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot. https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this bug, for details see: syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches`, https://goo.gl/tpsmEJ#testing-patches`,
extBugID2, crashLogLink, kernelConfigLink, reproSyzLink, reproCLink, extBugID2, crashLogLink, kernelConfigLink, reproSyzLink, reproCLink,
Expand Down
4 changes: 2 additions & 2 deletions dashboard/app/email_test.go
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See: syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot.`, https://goo.gl/tpsmEJ#status for how to communicate with syzbot.`,
extBugID0, crashLogLink, kernelConfigLink)) extBugID0, crashLogLink, kernelConfigLink))
c.checkURLContents(crashLogLink, crash.Log) c.checkURLContents(crashLogLink, crash.Log)
c.checkURLContents(kernelConfigLink, build.KernelConfig) c.checkURLContents(kernelConfigLink, build.KernelConfig)
Expand Down Expand Up @@ -211,7 +211,7 @@ See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this bug report. See: syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot. https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see: syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches`, https://goo.gl/tpsmEJ#testing-patches`,
extBugID1, reproSyzLink, crashLogLink, kernelConfigLink)) extBugID1, reproSyzLink, crashLogLink, kernelConfigLink))
Expand Down
4 changes: 3 additions & 1 deletion dashboard/app/mail_bisect_result.txt
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -22,4 +22,6 @@ git tree: {{.KernelRepoAlias}}
{{end}}{{if .ReproCLink}}C reproducer: {{.ReproCLink}} {{end}}{{if .ReproCLink}}C reproducer: {{.ReproCLink}}
{{end}}{{if .BisectCause.Commit}} {{end}}{{if .BisectCause.Commit}}
Reported-by: {{.CreditEmail}} Reported-by: {{.CreditEmail}}
Fixes: {{formatTagHash .BisectCause.Commit.Hash}} ("{{.BisectCause.Commit.Title}}"){{end}} Fixes: {{formatTagHash .BisectCause.Commit.Hash}} ("{{.BisectCause.Commit.Title}}")
{{end}}
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
3 changes: 2 additions & 1 deletion dashboard/app/mail_bug.txt
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot engineers can be reached at syzkaller@googlegroups.com.


syzbot will keep track of this bug report. See: syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#bug-status-tracking for how to communicate with syzbot.{{if or .ReproCLink .ReproSyzLink}} https://goo.gl/tpsmEJ#status for how to communicate with syzbot.{{if .BisectCause}}
For information about bisection process see: https://goo.gl/tpsmEJ#bisection{{end}}{{if or .ReproCLink .ReproSyzLink}}
syzbot can test patches for this bug, for details see: syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches https://goo.gl/tpsmEJ#testing-patches
{{- end -}} {{- end -}}
Expand Down

0 comments on commit 40fdabd

Please sign in to comment.