Skip to content

Commit

Permalink
dashboard/app: don't warn about emails on closed bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
dvyukov committed Jan 15, 2018
1 parent 66d492a commit 46d78f4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion dashboard/app/reporting.go
Expand Up @@ -396,7 +396,12 @@ func incomingCommandTx(c context.Context, now time.Time, cmd *dashapi.BugUpdate,
// but this is confusing and non-actionable for users.
// So now we fail the update, but give empty reason,
// which means "don't notify user".
log.Warningf(c, "Dup bug is already closed")
if cmd.Status == dashapi.BugStatusUpdate {
// This happens when people discuss old bugs.
log.Infof(c, "Dup bug is already closed")
} else {
log.Warningf(c, "Dup bug is already closed")
}
return false, "", nil
}
case BugStatusFixed, BugStatusInvalid:
Expand Down

0 comments on commit 46d78f4

Please sign in to comment.