Skip to content

Commit

Permalink
syz-manager: disable corpus rotation
Browse files Browse the repository at this point in the history
Temporary disable corpus rotation b/c we suspect it negatively affects fuzzing.
But we don't have hard data, and the easiest way to check is to disable
and see what happens.

Update #1348
  • Loading branch information
dvyukov committed Jan 7, 2020
1 parent d8c4574 commit 6a8d39b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion syz-manager/rpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ func (serv *RPCServer) Connect(a *rpctype.ConnectArgs, r *rpctype.ConnectRes) er
r.EnabledCalls = serv.enabledSyscalls
r.GitRevision = sys.GitRevision
r.TargetRevision = serv.target.Revision
if serv.mgr.rotateCorpus() && serv.rnd.Intn(3) != 0 {
// TODO: temporary disabled b/c we suspect this negatively affects fuzzing.
if false && serv.mgr.rotateCorpus() && serv.rnd.Intn(3) != 0 {
// We do rotation every other time because there are no objective
// proofs regarding its efficiency either way.
// Also, rotation gives significantly skewed syscall selection
Expand Down

0 comments on commit 6a8d39b

Please sign in to comment.