Skip to content

Commit

Permalink
pkg/report: parse "stack guard page was hit" better
Browse files Browse the repository at this point in the history
Now that we increased CONFIG_PRINTK_SAFE_LOG_BUF_SHIFT to 16
we started getting full parsable "stack guard page was hit" crashes.
Extract the anchor frame as we do for stalls.
This makes reports deterministic rather than point to a random top frame.
  • Loading branch information
dvyukov committed Jul 12, 2021
1 parent c06a9cf commit f415556
Show file tree
Hide file tree
Showing 4 changed files with 1,484 additions and 2 deletions.
4 changes: 3 additions & 1 deletion pkg/report/linux.go
Expand Up @@ -1239,9 +1239,11 @@ var linuxOopses = append([]*oops{
stack: &stackFmt{
parts: []*regexp.Regexp{
linuxRipFrame,
linuxCallTrace,
parseStackTrace,
},
extractor: linuxStallFrameExtractor,
},
noStackTrace: true,
},
{
title: compile("BUG: Invalid wait context"),
Expand Down
3 changes: 2 additions & 1 deletion pkg/report/testdata/linux/report/344
@@ -1,4 +1,5 @@
TITLE: BUG: stack guard page was hit in __udp6_lib_lookup
TITLE: BUG: stack guard page was hit in corrupted
CORRUPTED: Y

[ 760.482711] BUG: stack guard page was hit at 00000000397c6d92 (stack is 00000000a0f6b86a..000000000e6f9570)
[ 760.492602] kernel stack overflow (double-fault): 0000 [#1] PREEMPT SMP
Expand Down

0 comments on commit f415556

Please sign in to comment.