Failed to build due to multiple (different) declarations of printf in SOURCEDIR

[utkarsh009]

go build "-ldflags=-s -w -X github.com/google/syzkaller/sys.GitRevision=0a4d6e56b9194cd5c1022b6737367ff5bc368350+" -o bin/syz-extract ./sys/syz-extract
bin/syz-extract -build -os=netbsd -sourcedir=/extra/netbsd-src
generating netbsd/amd64...
extracting from fs.txt
failed to run compiler: exit status 1
/tmp/989350067.c:16:5: error: conflicting types for ‘printf’
 int printf(const char *format, ...);
     ^~~~~~
In file included from /extra/netbsd-src/sys/sys/timevar.h:66:0,
                 from /extra/netbsd-src/sys/sys/time.h:307,
                 from /extra/netbsd-src/sys/sys/stat.h:56,
                 from /tmp/989350067.c:5:
/extra/netbsd-src/sys/sys/systm.h:224:6: note: previous declaration of ‘printf’ was here
 void printf(const char *, ...) __printflike(1, 2);
      ^~~~~~

Makefile:188: recipe for target 'extract' failed
make: *** [extract] Error 1

I'll fix that in the source code. This is just for record.

[utkarsh009]

I have committed a fix to the repository. I'll post the link soon.

[utkarsh009]

http://mail-index.netbsd.org/source-changes/2017/10/27/msg089208.html
I have also tagged syzkaller.

[utkarsh009]

This change has been reverted and is thus, an open syzkaller bug. Probably the first thing to find out would be, where the first declaration of printf(9) comes from. So, where does 989350067.c come from?

[zoulasc]

look at issue 401

[utkarsh009]

Thanks! I’ll close the issue as soon as the pull request is accepted.

[dvyukov]

the pull request is merged