-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/cover: symbolization #4585
Comments
@dvyukov proposed third option. Let's remove addr2line dependency and parse DWARF data.
|
It turns out to be not that easy. LineReader has info about inlined frames, but only file:line, not the function name. And we need inline function names in both pkg/report and pkg/cover. |
File:line to function name looks doable having the source code itself. |
LineEntry has Column field: |
Is your feature request related to a problem? Please describe.
First /cover request with lazy symbolization - 19s.
Time to get updated numbers (after 5 seconds) - 17s.
RAM consumption 40G.
Describe the solution you'd like
Full symbolization costs 50 seconds and is comparable with syzkaller startup time (with QEMU).
Symbolizing all callbacks before first /cover call we can reduce its generation time to 3 seconds and memory consumption to 0G.
There are 2 potential solutions:
Second approach looks better but will cost more.
The text was updated successfully, but these errors were encountered: