-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm/adb: exitcode 255 on adb is normal behaviour #4807
Comments
I encountered this on a March 2023 Syzkaller version. I have updated to the latest commit but now I encounter: $ ~/opt/syzkaller/bin/syz-manager -config android.cfg -debug
2024/05/14 12:17:52 serving http on http://127.0.0.1:56741
2024/05/14 12:17:52 serving rpc on tcp://[::]:42085
2024/05/14 12:17:52 booting test machines...
2024/05/14 12:17:52 wait for the connection from test machine...
2024/05/14 12:17:53 executing adb [wait-for-device]
2024/05/14 12:17:53 adb returned
2024/05/14 12:17:53 executing adb [shell reboot]
2024/05/14 12:18:10 adb returned
2024/05/14 12:18:10 [FATAL] VM is exited while checking is not done |
Update: it's the same bug (exitcode 255) on the newest Syzkaller, but on the newer Syzkaller versions it doesn't loop reboots (which is normal). |
How do we know it has rebooted then? Isn't it a bug in adb? |
Good suggestion. I'll hit up the adb folks and report back when I have an update. |
The code in // History: adb reboot episodically hangs, so we used a more reliable way:
// using syz-executor to issue reboot syscall. However, this has stopped
// working, probably due to the introduction of seccomp. Therefore,
// we revert this to `adb shell reboot` in the meantime, until a more
// reliable solution can be sought out. Is this still the case? It seems If the issue from the comment isn't still the case, then I would suggest that replacing Cheers |
Just put my own AOSP userdebug build onto the target device and it works without trouble. I guess it is fixed |
Describe the bug
adb
returns exitcode 255 when performingadb shell reboot
, resulting in Syzkaller thinking therepair()
sequence failed, whilst the device is just rebooting. This causes anCreate()
device loop.To Reproduce
Run Syzkaller over (cabled) adb with a recent Google Pixel
Expected behavior
Syzkaller shouldn't treat exitcode 255 as error on reboot.
The text was updated successfully, but these errors were encountered: