executor: add cover protection support to OpenBSD #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 120 120
Lines 20884 20884
=======================================
Hits 14108 14108
Misses 6108 6108
Partials 668 668Continue to review full report at Codecov.
|
blackgnezdo
requested changes
Jun 5, 2019
executor/executor_bsd.h
Outdated
| mib[0] = CTL_HW; | ||
| mib[1] = HW_PAGESIZE; | ||
| len = sizeof(page_size); | ||
| if (sysctl(mib, 2, &page_size, &len, NULL, 0) != -1) |
There was a problem hiding this comment.
Which 2 is this? ARRAYSIZE(mib)?
| @@ -96,6 +110,9 @@ static void cover_unprotect(cover_t* cov) | |||
| #if GOOS_freebsd | |||
| size_t mmap_alloc_size = kCoverSize * KCOV_ENTRY_SIZE; | |||
| mprotect(cov->data, mmap_alloc_size, PROT_READ | PROT_WRITE); | |||
| #elif GOOS_openbsd | |||
| size_t mmap_alloc_size = kCoverSize * sizeof(uintptr_t); | |||
There was a problem hiding this comment.
Should this be a global const shared with above patch?
|
Which 2 is this? ARRAYSIZE(mib)?
Correct, fixed. Thanks, didn't known about ARRAYSIZE.
Should this be a global const shared with above patch?
Maybe, it would still have to defined per *BSD.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.