sys/linux: mptcp: Add netlink-API for MPTCP path-management #1815
+178
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
dvyukov
reviewed
Jun 11, 2020
| MPTCP_PM_ATTR_SUBFLOWS nlattr[MPTCP_PM_ATTR_SUBFLOWS, int32[0:8]] | ||
| ] [varlen] | ||
|
|
||
| mptcp_nl_addr_attr [ |
There was a problem hiding this comment.
Please use the existing kernel policy names. For this one it is: mptcp_pm_addr_policy:
https://elixir.bootlin.com/linux/latest/source/net/mptcp/pm_netlink.c#L383
This will allow syz-check to produce sys/linux/*.warn files and generally makes searching of the corresponding things in kernel easier.
| sendmsg$MPTCP_PM_CMD_SET_LIMITS(fd sock_nl_generic, msg ptr[in, msghdr_nl_mptcp[MPTCP_PM_CMD_SET_LIMITS]], f flags[send_flags]) | ||
| sendmsg$MPTCP_PM_CMD_GET_LIMITS(fd sock_nl_generic, msg ptr[in, msghdr_nl_mptcp[MPTCP_PM_CMD_GET_LIMITS]], f flags[send_flags]) | ||
|
|
||
| mptcp_nl_attr [ |
There was a problem hiding this comment.
Same here: mptcp_pm_policy
https://elixir.bootlin.com/linux/latest/source/net/mptcp/pm_netlink.c#L394
| @@ -0,0 +1,40 @@ | |||
| # Copyright 2018 syzkaller project authors. All rights reserved. | |||
MPTCP exposes a generic netlink API to control address advertisement and subflow-creation. syzkaller should make use of this interface.
|
@dvyukov - thanks for your feedback! I applied all the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPTCP exposes a generic netlink API to control address advertisement and
subflow-creation. syzkaller should make use of this interface.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md