docs/translations: Add a disclaimer and the first article in zh_CN #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mudongliang
commented
Mar 14, 2024
mudongliang
commented
- We add a disclaimer in docs/translations;
- We add the first article in docs/translations/zh_CN;
mudongliang
force-pushed
the
translation
branch
from
580776c
to
df8ca7a
Compare
dvyukov
reviewed
Mar 14, 2024
There was a problem hiding this comment.
CI also does not like this commit message:
Error: Wrong commit subject format: 'docs/translations/zh_CN: remove the trailing empty line in internals.md'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details.
But otherwise looks good.
Yes, adding more commits to fix this issue is not working. I reset the commits and remove the trailing empty line. Let's see CI's result |
Create a folder - translations to hold all language translations And add a disclaimer about these translations Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
1. add a link in README.md 2. add the first article in Chinese Simplified. Note that, since this article has links about many other untranslated articles, our policy is to keep the English version. We will update these links once these articles are translated. Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
mudongliang
force-pushed
the
translation
branch
from
df8ca7a
to
5ff1552
Compare
dvyukov
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.