Skip to content

Add proc type#94

Merged
dvyukov merged 1 commit intogoogle:masterfrom
xairy:proc-type
Nov 25, 2016
Merged

Add proc type#94
dvyukov merged 1 commit intogoogle:masterfrom
xairy:proc-type

Conversation

@xairy
Copy link
Contributor

@xairy xairy commented Nov 25, 2016

No description provided.

sys/README.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend this description. It is very non-obvious type. I doubt that anybody expect me and you understand what it does.
A usage example may help.

@dvyukov
Copy link
Collaborator

dvyukov commented Nov 25, 2016

Please write some meaningful commit description. There are people who read them.
Also prefix commit with package name: "sys: add proc type".

prog/rand.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "- 1"? Does not look correct to me. Should crash if ValuesPerProc==1.

sysgen/sysgen.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex uses 20 procs. Let's make the max 32. And check that procs parameter <= 32 in config package.

ipc/ipc.go Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pid should be an argument to ipc.MakeEnv.
We've discussed that we may need to pass pid to executor to setup network card, etc.
MakeEnv looks like the right place for pid long term.

@xairy
Copy link
Contributor Author

xairy commented Nov 25, 2016

All done.

Note, that the old way to generate ports is still used when generating inaddrs.
I'll move it to syscall templates.

@dvyukov
Copy link
Collaborator

dvyukov commented Nov 25, 2016

looks good to me

@dvyukov dvyukov merged commit 52f7310 into google:master Nov 25, 2016
@xairy xairy deleted the proc-type branch May 30, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants