Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

SyzyASAN - ignore NULL pointer accesses? #17

Open
sigurasg opened this issue Aug 10, 2015 · 4 comments
Open

SyzyASAN - ignore NULL pointer accesses? #17

sigurasg opened this issue Aug 10, 2015 · 4 comments

Comments

@sigurasg
Copy link
Contributor

SyzyASAN seems to be reporting NULL pointer, and near-NULL pointer accesses as ASAN issues. The first 64K of user memory is unmapped by default (convention?), so this is somewhat redundant. Maybe it's better to greenzone the first 64K in shadow and just let these crash.

@plmonette-zz plmonette-zz self-assigned this Aug 12, 2015
plmonette-zz added a commit that referenced this issue Aug 24, 2015
It will still report near-nullptr accesses if it detect heap corruption.

BUG=#17
R=chrisha@chromium.org

Review URL: https://codereview.chromium.org/1302943002 .
@chhamilton
Copy link
Contributor

Bruce Dawson suggested that we should never wrap the original exception, even if we've augmented the crash report with additional information. Wrapping page violations / null pointer dereferences / etc actually hides the underlying error, and they all bucket under the SyzyASAN UNKNOWN crash type. I think that's a great follow-up for plmonette's CL.

@sebmarchand
Copy link
Contributor

Does that mean that we should maybe disable the unhandled exception filter ?

@chhamilton
Copy link
Contributor

No, we still want the filter to be able to analyze memory and add information about memory corruption, etc. But we don't need to wrap the exception record with our own one in this case.

@chhamilton
Copy link
Contributor

This has been partially addressed by plmonette's CL. However, to close this let's not wrap UnhandledExceptionFilter bugs at all, but rather only augment them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants