Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to PyPI with GH Action #131

Merged
merged 51 commits into from Jun 8, 2023
Merged

Publish to PyPI with GH Action #131

merged 51 commits into from Jun 8, 2023

Conversation

ianspektor
Copy link
Collaborator

@ianspektor ianspektor commented May 17, 2023

  • Added publish.yaml action which builds, tests and publishes wheels + source for all supported python versions for linux and macos
  • Had to remove the usage of @classmethod, @Property and @AbstractMethod when used together (removed the property decorator) since py3.8 failed to understand it correctly
  • Removed all uses of list, dict, tuple instead of typing.List, etc. as type hints for py3.8
  • Had to make the build_manylinux script build for a single version, added build_manylinux_all which builds all of them
  • Added all supported python versions to tests workflow
  • Added manual confirmation step before publishing to pypi:
image

TODO:

  • add prod pypi token to pypi environment's secrets in the repo's settings
  • change test-pypi to pypi environment in publish step
  • change branches: to release in publish action
  • roll version back to 0.1.0

@ianspektor ianspektor force-pushed the publish-action branch 9 times, most recently from df814ef to 6d87271 Compare May 17, 2023 17:57
Copy link
Collaborator

@rstz rstz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few minor things

pyproject.toml Outdated Show resolved Hide resolved
tools/build.md Outdated Show resolved Hide resolved
tools/build.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@rstz rstz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few minor things

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
@ianspektor ianspektor temporarily deployed to test-pypi June 7, 2023 14:23 — with GitHub Actions Inactive
@ianspektor ianspektor temporarily deployed to test-pypi June 7, 2023 14:35 — with GitHub Actions Inactive
Copy link
Collaborator

@DonBraulio DonBraulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🙌🙌

@ianspektor ianspektor temporarily deployed to test-pypi June 7, 2023 14:44 — with GitHub Actions Inactive
@ianspektor ianspektor temporarily deployed to test-pypi June 7, 2023 15:20 — with GitHub Actions Inactive
@rstz
Copy link
Collaborator

rstz commented Jun 8, 2023

LGTM again, thank you for the changes :)

@ianspektor ianspektor merged commit 6f72571 into main Jun 8, 2023
12 checks passed
@ianspektor ianspektor deleted the publish-action branch June 8, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants