Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies and other cleanups #145

Merged
merged 10 commits into from Jun 6, 2023
Merged

Dependencies and other cleanups #145

merged 10 commits into from Jun 6, 2023

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Jun 2, 2023

This PR is based on #144

@achoum achoum marked this pull request as ready for review June 2, 2023 12:32
@achoum achoum requested a review from rstz June 5, 2023 06:29
@@ -18,7 +18,7 @@
"editor.defaultFormatter": "ms-python.black-formatter"
},
"editor.tabSize": 4,
"editor.formatOnSave": true,
"editor.formatOnSave": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not too familiar with vscode, but should this file be part of the repo at all?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My version of code (possibly the same for you) has issues with black formatting, so I need to run it manually.
formatOneSave will messup files.

@achoum achoum merged commit 8c1c5ae into main Jun 6, 2023
4 checks passed
@achoum achoum deleted the gbm_import branch June 6, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants