New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create M5 notebook #150
Create M5 notebook #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool change! Left minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to tutorials/index.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple typos in the first block:
nodebook
, engenering
, forecating
, specificaly
we shows
->we show
will applied
->will be applied
over the last , 7, 14
(remove comma)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Re-run to show interactive plot sales (for some reason they're not shown)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: make scrollable the cell output where fit
is executed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Link added to index.md.
*Fix typos.
*Re-run all cells
make scrollable the cell output where fit is executed.
I did not knew about this feature :)
temporian/core/operators/tick.py
Outdated
input: Guide node. The start and end time boundaries to generate the new | ||
timestamps are defined by the range of timestamps in `input`. | ||
interval: Tick interval. | ||
align: If false, the first tick is generated at the first timestamp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the align name here is confusing.
If you think about the begin tick and the sequence of generated ticks, saying that they're "aligned" means that they match at the beginning, but the opposite is true here.
I guess the name comes from aligning ticks to zero? Maybe align_to_zero?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, "align" means that the timestamps will be multiple of "interval".
This is the same as "align" in c++ / asm.
*Adding this to the agenda.
Also