Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide pylint warnings for internal imports #165

Merged
merged 1 commit into from Jun 29, 2023
Merged

Conversation

ianspektor
Copy link
Collaborator

Pylint started marking all internal imports as missing since I manually removed the core, implementation, etc. symbols from the package, added it to ignores

Copy link
Collaborator

@achoum achoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it means the lint error is disabled for all the callers of temporian, or just for the temporian code?

If this is the second option, looks good. If this is the first option, I think this might be an issue.

@ianspektor
Copy link
Collaborator Author

Does it means the lint error is disabled for all the callers of temporian, or just for the temporian code?

just the temporian code 😄 the [tool.XXX] sections in the pyproject.toml are configuration sections for tools in our development environments

Copy link
Collaborator

@achoum achoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sg then :)

@ianspektor ianspektor merged commit f1c1c4b into main Jun 29, 2023
12 checks passed
@ianspektor ianspektor deleted the fix-pylint-warnings branch June 29, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants