Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tp.join #177

Merged
merged 9 commits into from Jul 5, 2023
Merged

tp.join #177

merged 9 commits into from Jul 5, 2023

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Jun 30, 2023

No description provided.

@achoum achoum marked this pull request as ready for review June 30, 2023 15:09
DonBraulio
DonBraulio approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@DonBraulio DonBraulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee 🙌

Let's discuss tomorrow if it makes sense to add some ticket with outer join and str type support.

temporian/core/operators/test/join_test.py Outdated Show resolved Hide resolved
temporian/core/operators/join.py Show resolved Hide resolved
temporian/core/operators/join.py Show resolved Hide resolved
temporian/implementation/numpy/operators/join.py Outdated Show resolved Hide resolved
temporian/implementation/numpy/operators/test/join_test.py Show resolved Hide resolved
@ianspektor
Copy link
Collaborator

Make sure to merge main and add @compile decorator to new ops before merging 👮🏼

@achoum
Copy link
Collaborator Author

achoum commented Jul 4, 2023

Thanks

@achoum achoum merged commit f8eeb7b into main Jul 5, 2023
7 checks passed
@achoum achoum deleted the gbm_join branch July 5, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonBraulio DonBraulio DonBraulio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achoum @ianspektor @DonBraulio