Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internally, tp uses bytes instead of int32 unicodes #190

Merged
merged 11 commits into from Jul 12, 2023
Merged

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Jul 11, 2023

No description provided.

@achoum achoum marked this pull request as ready for review July 11, 2023 18:48
@achoum achoum requested a review from rstz July 12, 2023 06:53
Copy link
Collaborator

@rstz rstz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/src/reference/temporian/dtypes/bytes_.md Outdated Show resolved Hide resolved
temporian/beam/io.py Show resolved Hide resolved
temporian/beam/io.py Show resolved Hide resolved
temporian/core/data/dtype.py Show resolved Hide resolved
temporian/implementation/numpy/data/event_set.py Outdated Show resolved Hide resolved
temporian/implementation/numpy/data/event_set.py Outdated Show resolved Hide resolved
@achoum achoum merged commit 4e27d4f into main Jul 12, 2023
12 checks passed
@achoum achoum deleted the gbm_strings_are_bytes branch July 12, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants