Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve beam backend #196

Merged
merged 5 commits into from Jul 18, 2023
Merged

Improve beam backend #196

merged 5 commits into from Jul 18, 2023

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Jul 14, 2023

  • Solve typing issues
  • Add support for new input / output format

@achoum achoum marked this pull request as ready for review July 14, 2023 15:01
@achoum achoum requested a review from ianspektor July 14, 2023 15:19
ianspektor
ianspektor approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@ianspektor ianspektor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impossible for me to review the beam code atm, I'll send comments once I dive into it while developing a feature on it :) Left some comments on api

temporian/beam/io.py Show resolved Hide resolved
temporian/beam/io.py Show resolved Hide resolved
temporian/beam/io.py Outdated Show resolved Hide resolved
temporian/beam/io.py Outdated Show resolved Hide resolved
DonBraulio
DonBraulio approved these changes Jul 17, 2023
View reviewed changes
temporian/beam/test/utils.py Outdated Show resolved Hide resolved
temporian/beam/operators/select.py Show resolved Hide resolved
temporian/beam/test/io_test.py Show resolved Hide resolved
@achoum
Copy link
Collaborator Author

achoum commented Jul 18, 2023

Thanks

@achoum achoum merged commit d777dcf into main Jul 18, 2023
12 checks passed
@achoum achoum deleted the gbm_beam branch July 18, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonBraulio DonBraulio DonBraulio approved these changes

@ianspektor ianspektor ianspektor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achoum @DonBraulio @ianspektor