Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime checking + application to 3 functions in the API #205

Merged
merged 16 commits into from Jul 31, 2023
Merged

Runtime checking + application to 3 functions in the API #205

merged 16 commits into from Jul 31, 2023

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Jul 19, 2023 •
edited

This is a proposal for the runtime checker. Currently only 3 functions are instrumented.

@achoum achoum marked this pull request as ready for review July 19, 2023 15:59
@achoum achoum requested a review from ianspektor July 19, 2023 16:00
ianspektor
ianspektor approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@ianspektor ianspektor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Quite a bit of code but very clear to understand, does exactly what we need, easy to extend to new types we need, and we don't add an extra/possibly slow dependency. Thanks!

docs/markdown_code_examples_test.py Outdated Show resolved Hide resolved
temporian/core/compilation.py Outdated Show resolved Hide resolved
temporian/utils/rtcheck.py Show resolved Hide resolved
temporian/utils/rtcheck.py Outdated Show resolved Hide resolved
temporian/utils/rtcheck.py Outdated Show resolved Hide resolved
temporian/utils/rtcheck.py Show resolved Hide resolved
temporian/utils/rtcheck.py Outdated Show resolved Hide resolved
temporian/utils/rtcheck.py Outdated Show resolved Hide resolved
temporian/utils/test/rtcheck_test.py Show resolved Hide resolved
temporian/utils/test/rtcheck_test.py Outdated Show resolved Hide resolved
@achoum
Copy link
Collaborator Author

achoum commented Jul 31, 2023

Thanks

@achoum achoum merged commit 28a1af3 into main Jul 31, 2023
13 checks passed
@achoum achoum deleted the gbm_rtcheck branch July 31, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianspektor ianspektor ianspektor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achoum @ianspektor