Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for restructuring tests with a single op (as discussed last meeting):
@parametrize
which decreases amount of work and code by a lot, but makes the actual code in the test harder to understand (this case is especially hard though because of needing to use different samplings and window lengths and such depending on what was received as params). what do you think?migrating this for a single op was about 2h, but its the first one (so lots of time invested in deciding what to do) and it was a well-tested one. I'd expect the mean time to migrate an arbitrary op to be around 30m worst case, which sums up to about 1 week of full time work for our 75 ops :)