Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: This PR fixes some issues in
normalize_timestamps()
, simplifying the code, avoiding issues with numpy dtypes, and improving the error handling by avoiding unnecessary checks.For context, this fixes an issue that showed up in a notebook by @achoum, caused by numpy representing numbers using
np.longlong
internally instead of the usualnp.int64
, after loading a CSV from pandas. This can be reproduced by doing:The bug is solved by using
np.issubdtype(np.dtype, np.integer)
, instead of accessingmy_array.dtype.type
which refers to the underlying scalar type, and there are a bunch of those (see Built in scalar types).