Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an AMOC to the abnormality detection tutorial #279

Merged
merged 9 commits into from Oct 10, 2023
Merged

Adds an AMOC to the abnormality detection tutorial #279

merged 9 commits into from Oct 10, 2023

Conversation

achoum
Copy link
Collaborator

@achoum achoum commented Oct 8, 2023 •
edited

Computes the AMOC on the abnormality detection tutorial.

Some ideas for later:

  • Remove or adapt the feature preprocessing
  • Talk about the difference between AMOC and AUC, and how AUC can lead to wrong impressions on the model.
  • Adds the AMOC computation as part of Temporian.
  • Talks about curse of dimensionality for abnormality detection.

@achoum achoum marked this pull request as ready for review October 8, 2023 16:09
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Coverage report

Main: 90.50% | PR: 90.51% | Diff: 0.01 ✅

ianspektor
ianspektor approved these changes Oct 9, 2023
View reviewed changes
temporian/implementation/numpy/data/plotter.py Outdated Show resolved Hide resolved
docs/src/tutorials/anomaly_detection_unsupervised.ipynb Outdated Show resolved Hide resolved
docs/src/tutorials/anomaly_detection_unsupervised.ipynb Outdated Show resolved Hide resolved
@google google deleted a comment from github-actions bot Oct 9, 2023
@google google deleted a comment from github-actions bot Oct 9, 2023
@google google deleted a comment from github-actions bot Oct 9, 2023
@google google deleted a comment from github-actions bot Oct 9, 2023
@github-actions
Copy link

Coverage report

Main: 90.55% | PR: 90.56% | Diff: 0.01 ✅

1 similar comment
@github-actions
Copy link

Coverage report

Main: 90.55% | PR: 90.56% | Diff: 0.01 ✅

@github-actions
Copy link

Coverage report

Main: 90.71% | PR: 90.73% | Diff: 0.01 ✅

@achoum achoum merged commit 93f1d76 into main Oct 10, 2023
20 checks passed
@achoum achoum deleted the gbm_amoc branch October 10, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianspektor ianspektor ianspektor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achoum @ianspektor