Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notebooks display in docs #298

Merged
merged 3 commits into from Nov 6, 2023
Merged

fix notebooks display in docs #298

merged 3 commits into from Nov 6, 2023

Conversation

ianspektor
Copy link
Collaborator

notebook display was broken after #290 (great catch by @DonBraulio), this fixes it

Copy link

github-actions bot commented Nov 1, 2023

Coverage report

Main: 90.84% | PR: 90.84% | Diff: 0.00 ✅

Copy link

github-actions bot commented Nov 1, 2023

Coverage report

Main: 90.77% | PR: 90.77% | Diff: 0.00 ✅

@DonBraulio
Copy link
Collaborator

It's better now but the code cells are behaving weird, right? The code text swaps color according to theme, but the background is always dark (which makes it hard to read with light theme text)

Copy link

github-actions bot commented Nov 2, 2023

Coverage report

Main: 91.11% | PR: 91.11% | Diff: 0.00 ✅

Copy link
Collaborator

@DonBraulio DonBraulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌🙌🙌

@ianspektor ianspektor merged commit b4862f5 into main Nov 6, 2023
20 checks passed
@ianspektor ianspektor deleted the fix-notebooks branch November 6, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants